Patch set 5:Code-Review +1

View Change

2 comments:

• Commit Message:

  • Patch Set #5, Line 10:

    Also remove CONFIG(GENERATE_SMBIOS_TABLES) compile option because SMBIOS
    is always enabled and it makes the code cleaner.
    

    Another approach is to move all SMBIOS stuff into a `smbios.c` file 😊

• File src/mainboard/ocp/deltalake/ramstage.c:

  • Patch Set #5, Line 246: dimm_locator[dimm->channel_num]

    I would just do:

     'A' + dimm->channel_num

To view, visit change 45799. To unsubscribe, or for help writing mail filters, visit settings.