Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35246 )
Change subject: mb/emulation/qemu-riscv: Implement ipi using clint to enable smp in qemu/spike. ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35246/3/src/mainboard/emulation/spi... File src/mainboard/emulation/spike-riscv/clint.c:
https://review.coreboot.org/c/coreboot/+/35246/3/src/mainboard/emulation/spi... PS3, Line 31: write32((void *)(SPIKE_CLINT_BASE + 4 * (uintptr_t)hartid), !!val);
the uintptr_t confused me, is it necessary?
Ack