Attention is currently required from: Tim Wawrzynczak, Angel Pons.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50858 )
Change subject: soc/intel/common: Add function to lpc_lib to return PIRQ routing
......................................................................
Patch Set 14: Code-Review+2
(2 comments)
Patchset:
PS14:
PIRQ_* are redefined somewhere in the last few patchsets of 50857 as Angel mentioned.
Ah, my mistake. Initially, I tried cherry-picking that CL to the firmware branch and it ran into conflicts, which made me realize that I should be doing this on top-of-tree main, so I switched to main, but went on to cherry-pick the next CL in the stack instead of the base CL again as I had copied the next cherry-pick command before the previous one finished.
PS14:
Works on my voxel.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50858
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib215fba54573c50a88aa4584442bd8d27ae017be
Gerrit-Change-Number: 50858
Gerrit-PatchSet: 14
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 07 Apr 2021 19:39:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment