Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34877 )
Change subject: mb/google/kukui: Move panel description to CBFS files ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34877/7/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/34877/7/src/mainboard/google/kukui/... PS7, Line 105: static u8 buffer[8 * 1024]; Sorry, why did all this revert to the old code again? I think you must have pushed from the wrong branch or something...
https://review.coreboot.org/c/coreboot/+/34877/7/src/mainboard/google/kukui/... PS7, Line 138: } Having the assert(panel->s) here could be useful if you're worried that one of the per-board implementations of get_panel_description() could screw up. But not vital.