Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 38:
(4 comments)
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/Kconfig:
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... PS38, Line 39: default BOARD_ASUS_A88XM_E_DDR3_VOLT_150
Unconfirmed copy-paste from f2a85-m ?
Confirmed copy-paste ;) Which seems to work - for 1.50v RAM at least.
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... PS38, Line 104: * Untested: HDMI
Note: DVI can be either `ConnectorTypeSingleLinkDVI` or `ConnectorTypeDualLinkDVI`.
This board has only one HDMI, which is working well by the way - tested. Don't know why the code below sets up for 2 HDMI, maybe another one isn't "soldered" ?
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/bootblock.c:
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... PS38, Line 33: reg32 = CONFIG_BOARD_ASUS_A88XM_E_DDR3_VOLT_VAL;
They might have the same voltage regulator. […]
If you are about this DigiVRM chip: on A88XM-E it is ASP1206 while i.e. on F2A85-M PRO it is ASP1107. They are from the same family and probably have the same interface.
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... PS38, Line 61: ite_enable_3vsbsw(gpio);
Might be needed as well, if the boards have the same SIO.
Both F2A85-M and A88XM-E have the same ITE IT8603E as SuperIO.