[coreboot-gerrit] Change in coreboot[master]: fw_config: Add firmware configuration interface

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41209 )

Change subject: fw_config: Add firmware configuration interface
......................................................................

Patch Set 9:
> Patch Set 9:
> > Patch Set 9:
> >
> > (1 comment)
> >
> > I did not really review the work here, I just wanted to leave a general (possibly unrelated) comment that linking static.c into SMM is IMHO a bad idea since the copy of devicetree there does not reflect any modifications ramstage could have made.
>
> Only static.h might end up included indirectly in smm and it just contains some #define.  I did add a build dependency on smm code, but just to ensure that an indirect include of static.h wouldn't fail to compile.

It is not touched with your work, but currently we do have this:
Makefile.inc:smm-y+=$(DEVICETREE_STATIC_C)

With mutable configuration bits in ramstage, SMM will not have correct runtime information.