Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38826 )
Change subject: mb/google/hatch: Create nightfury variant
......................................................................
Patch Set 45:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38826/45/src/mainboard/google/hatch...
File src/mainboard/google/hatch/variants/nightfury/ramstage.c:
https://review.coreboot.org/c/coreboot/+/38826/45/src/mainboard/google/hatch...
PS45, Line 23: /*
: * Enable power to FPMCU, wait for power rail to stabilize,
: * and then deassert FPMCU reset.
: * Waiting for the power rail to stabilize can take a while,
: * a minimum of 400us on Nightfury.
: */
But there's no code here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38826
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If08692f4a2d216c57499098cc0e35abd708d99d4
Gerrit-Change-Number: 38826
Gerrit-PatchSet: 45
Gerrit-Owner: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 13 Mar 2020 09:23:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment