Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36210 )
Change subject: security/vboot: Add new Kconfig option VBOOT_EARLY_EC_SYNC
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36210/2/src/security/vboot/Makefile...
File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36210/2/src/security/vboot/Makefile...
PS2, Line 40: sync_ec.c
Might want to call this file ec_sync.c to be more consistent with vboot's naming...
Done
https://review.coreboot.org/c/coreboot/+/36210/2/src/security/vboot/Makefile...
PS2, Line 134: CFLAGS_common += -I3rdparty/vboot/firmware/2lib/include
: CFLAGS_common += -I3rdparty/vboot/firmware/lib/include
Rather than adding vboot1 dependencies in coreboot (which I already worked really hard to get rid of […]
Sure. Sorry, I don't have all the historical context here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36210
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56edcd385467edb5e91168dc59427d86fa9581d7
Gerrit-Change-Number: 36210
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 22 Oct 2019 16:01:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Gerrit-MessageType: comment