John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40425 )
Change subject: mb/google/volteer: Add support for USB Type-C ports
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40425/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/acpi/usbc.asl:
https://review.coreboot.org/c/coreboot/+/40425/1/src/mainboard/google/voltee...
PS1, Line 24: "normal"
Heikki's comment: "Those names are now reserved for generic references that point to the actual usb3 […]
For "normal" description, as quoted from Heikki "the value must be a string for those properties, so it's correct as-is. We just convert the strings to integers in the code."
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40425
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b443a1ca1c5361652a69586b340b1c95e9c3f06
Gerrit-Change-Number: 40425
Gerrit-PatchSet: 3
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Caveh Jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Prashant Malani
pmalani@google.com
Gerrit-Comment-Date: Fri, 24 Apr 2020 02:26:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Comment-In-Reply-To: Prashant Malani
pmalani@google.com
Gerrit-MessageType: comment