Attention is currently required from: Dinesh Gehlot, Eric Lai, Ivan Chen, Kapil Porwal, Martin L Roth, Matt DeVillier, Nick Vaccaro, Paul Menzel, Subrata Banik.
Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80769?usp=email )
Change subject: mb/google/brya/var/omniknight: remove Implement touchscreen power sequencing
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
if the issue is the touchscreen being powered on before BL_EN, then I ask again: […]
From Schematic, although BL_EN is output from the CPU, it seems that the BL_EN pin cannot be controlled from gpio.c.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80769?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I66f4a7915f135927fbc0a16254dece202dfc23a2
Gerrit-Change-Number: 80769
Gerrit-PatchSet: 7
Gerrit-Owner: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Ivan Chen
yulunchen@google.com
Gerrit-Comment-Date: Wed, 06 Mar 2024 01:10:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment