HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39821 )
Change subject: nb/i945: Split raminit into desktop and mobile version ......................................................................
Patch Set 18:
(3 comments)
Thx
https://review.coreboot.org/c/coreboot/+/39821/16/src/northbridge/intel/i945... File src/northbridge/intel/i945/raminit_i945gc.c:
https://review.coreboot.org/c/coreboot/+/39821/16/src/northbridge/intel/i945... PS16, Line 913: MCHBAR8(C0R0B00DQST + (i * 0x10) + 8) = channeldll & 0xff;
Don't move this write
Done
https://review.coreboot.org/c/coreboot/+/39821/16/src/northbridge/intel/i945... PS16, Line 2149: if ((sysinfo->dimm[0] == SYSINFO_DIMM_NOT_POPULATED &&
Don't change this here please. It breaks verification...
Done
https://review.coreboot.org/c/coreboot/+/39821/16/src/northbridge/intel/i945... PS16, Line 2198: if (sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED)
Why did the CLOCKS_WIDTH macro disappear?
Done