Marx Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38741 )
Change subject: soc/intel/cannonlake: Add tdc config for CML ......................................................................
Patch Set 3:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/in... File src/soc/intel/cannonlake/include/soc/vr_config.h:
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/in... PS3, Line 57: TDC
Can you make this comment say 'Thermal Design Current' so it is clear without needing to decode an a […]
that's a good suggestion.
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/vr... File src/soc/intel/cannonlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/vr... PS3, Line 472: tdc[VR_IA_CORE] = (cfg->cpu_pl2_4_cfg == baseline) ? VR_CFG_TDC_AMP(117) : VR_CFG_TDC_AMP(146);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/vr... PS3, Line 474: tdc[VR_IA_CORE] = (cfg->cpu_pl2_4_cfg == baseline) ? VR_CFG_TDC_AMP(86) : VR_CFG_TDC_AMP(125);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/vr... PS3, Line 502: printk(BIOS_ERR, "ERROR: Unknown MCH (0x%x) in VR-config and apply Auto/default settings\n", mch_id);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/vr... PS3, Line 558: 1
Hi Marx, […]
will add "tdc_disable" in the device_tree for users to configure so that it will be enabled by default if users don't add it in the device_tree.
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/vr... PS3, Line 559:
extra newline
Done