[coreboot-gerrit] Change in coreboot[master]: util/crossgcc/patches: facilitate successful build of ipxe

[Martin Roth (Code Review)]

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35098 )

Change subject: util/crossgcc/patches: facilitate successful build of ipxe
......................................................................

util/crossgcc/patches: facilitate successful build of ipxe

New changes in the latest binutils 2.32 lead to assembler errors causes
ipxe build failure. IPXE uses the divide test which requires /dev/null as
input as well as the output file name.

This patch facilitates the /dev/null as an exception to the current
changes in binutils package while building crossgcc for coreboot leads to
successful build of ipxe and further tests to pass based on /dev/null and
applies automatically during the crossgcc rebuild.

Also, this can be reverted once binutils/ipxe provides an updated release
in this respect.

Fixes: https://ticket.coreboot.org/issues/204

Change-Id: I9f664829b8c42420c0b2ab1f2316150f86ac0b1a
Signed-off-by: Himanshu Sahdev 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35098
Reviewed-by: Martin Roth 
Reviewed-by: Paul Menzel 
Reviewed-by: HAOUAS Elyes 
Tested-by: build bot (Jenkins) 
---
A util/crossgcc/patches/binutils-2.32_as-ipxe.patch
1 file changed, 36 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  HAOUAS Elyes: Looks good to me, but someone else must approve

diff --git a/util/crossgcc/patches/binutils-2.32_as-ipxe.patch b/util/crossgcc/patches/binutils-2.32_as-ipxe.patch
new file mode 100644
index 0000000..4d2c00a
--- /dev/null
+++ b/util/crossgcc/patches/binutils-2.32_as-ipxe.patch
@@ -0,0 +1,36 @@
+From 6984bd861cc595e56d26ea033851d9174e855129 Mon Sep 17 00:00:00 2001
+From: Himanshu Sahdev aka CunningLearner 
+Date: Mon, 26 Aug 2019 16:57:13 +0530
+Subject: [PATCH] as: facilitate tests based on /dev/null
+
+Signed-off-by: Himanshu Sahdev 
+
+---
+ gas/as.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/gas/as.c b/gas/as.c
+index 728811bc..78b4802c 100644
+--- a/gas/as.c
++++ b/gas/as.c
+@@ -1203,7 +1203,7 @@ main (int argc, char ** argv)
+ {
+   char ** argv_orig = argv;
+   struct stat sob;
+-
++  const char *dev_null_file="/dev/null";
+   int macro_strip_at;
+ 
+   start_time = get_run_time ();
+@@ -1252,7 +1252,7 @@ main (int argc, char ** argv)
+      so that switches like --hash-size can be honored.  */
+   parse_args (&argc, &argv);
+ 
+-  if (argc > 1 && stat (out_file_name, &sob) == 0)
++  if (argc > 1 && stat (out_file_name, &sob) == 0 && strcmp(out_file_name,dev_null_file)!=0)
+     {
+       int i;
+ 
+-- 
+2.17.1
+