11 May
2021
11 May
'21
10:02 p.m.
Attention is currently required from: Jason Glenesk, Marshall Dawson, Julian Schroeder, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54065 )
Change subject: amd/cezanne: adding support for the changed AMD FSP API for USB PHY ......................................................................
Patch Set 3:
(1 comment)
File src/vendorcode/amd/fsp/cezanne/FspUsb.h:
https://review.coreboot.org/c/coreboot/+/54065/comment/4dee2841_86413341 PS1, Line 44: compdstune
This stuff is explained in the USB2 spec and the PPR. […]
Can you maybe add some breadcrumbs on where to look for these parameters? Right now I have no idea what these mean or where the documentation is for them.
--
To view, visit https://review.coreboot.org/c/coreboot/+/54065
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I011ca40a334e4fd26778ca7f18b653298b14019b
Gerrit-Change-Number: 54065
Gerrit-PatchSet: 3
Gerrit-Owner: Julian Schroeder julianmarcusschroeder@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Julian Schroeder julianmarcusschroeder@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 11 May 2021 20:02:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Julian Schroeder julianmarcusschroeder@gmail.com
Gerrit-MessageType: comment