build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62096 )
Change subject: device: Add more HyperTransport definitions ......................................................................
Patch Set 1:
(6 comments)
File src/include/device/hypertransport.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141273): https://review.coreboot.org/c/coreboot/+/62096/comment/82821055_0fa728dd PS1, Line 11: #define HT_PRIMARY_BASE_UNIT_ID_OFFSET 0 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141273): https://review.coreboot.org/c/coreboot/+/62096/comment/93eb88de_2ee73c0d PS1, Line 13: #define HT_PRIMARY_UNIT_COUNT_OFFSET 5 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141273): https://review.coreboot.org/c/coreboot/+/62096/comment/8bcf9c55_e8e3f0af PS1, Line 25: /* Common Comand Register Bits */ 'Comand' may be misspelled - perhaps 'Command'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141273): https://review.coreboot.org/c/coreboot/+/62096/comment/b42faf1d_ea590831 PS1, Line 29: #define HT_CMD_CAP_OFFSET 13 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141273): https://review.coreboot.org/c/coreboot/+/62096/comment/dc1bfd79_5139afb0 PS1, Line 109: /* Each bit set in this register indicates suport for the frequency from the 'suport' may be misspelled - perhaps 'support'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141273): https://review.coreboot.org/c/coreboot/+/62096/comment/0bb0d322_a8186d08 PS1, Line 136: #define HT_FEATURE_CAP_64B_ADRESSING BIT(4) 'ADRESSING' may be misspelled - perhaps 'ADDRESSING'?