Jonas M has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38204 )
Change subject: [WIP]mainboard/lenovo: do initial commit for t540p
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/38204/3/src/mainboard/lenovo/t540p/...
File src/mainboard/lenovo/t540p/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38204/3/src/mainboard/lenovo/t540p/...
PS3, Line 22: GMA_INT15_ACTIVE_LFP_INT_LVDS
Shouldn't this be GMA_INT15_ACTIVE_LFP_EDP?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38204
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02ecde6999d1b5ca7741371273edd90297899fa0
Gerrit-Change-Number: 38204
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Elsen
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Jonas M
ad-min@mailbox.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Elsen
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Comment-Date: Fri, 17 Apr 2020 20:20:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment