Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38755 )
Change subject: nb/amd/{agesa,pi}/acpi: include thermal zone
......................................................................
Patch Set 1:
Patch Set 1:
Sorry, there's some misunderstanding. I didn't doubt that the
HTC feature is configured correctly.
I doubt that the thermal_mix.asl code is actually useful with
correctly configured HTC. If I read it correctly, it would
prevent HTC to become active (powers down long before that
would happen).
Okay, so are you referring to this line?
Return (Subtract (_CRT, K10TEMP_HOT_OFFSET))
Or I am still missing your point (or something obvious)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38755
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icbdf44508085964452d74e084b133f1baa39e1a8
Gerrit-Change-Number: 38755
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 17 Feb 2020 11:09:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment