Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34589 )
Change subject: AGESA: Fix discovery of IO APICs number ......................................................................
Patch Set 5: -Code-Review
(2 comments)
oops, the commit message reverted to the patchset 2 state (while it was much better in ps #3)
https://review.coreboot.org/c/coreboot/+/34589/4/src/drivers/amd/agesa/state... File src/drivers/amd/agesa/state_machine.c:
https://review.coreboot.org/c/coreboot/+/34589/4/src/drivers/amd/agesa/state... PS4, Line 297: int amd_get_ioapic_num(void) {
This should be addressed.
Done
https://review.coreboot.org/c/coreboot/+/34589/4/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family15tn/northbridge.c:
https://review.coreboot.org/c/coreboot/+/34589/4/src/northbridge/amd/agesa/f... PS4, Line 873: u8 plat_num_io_apics = amd_get_ioapic_num();
Nit: maybe this can be made const
Ack, but it was a non-const constant before, so... ;-)