Attention is currently required from: Raul Rangel.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67193 )
Change subject: util/lint/lint: Add -I option to invert test results
......................................................................
Patch Set 1:
(1 comment)
File util/lint/lint:
https://review.coreboot.org/c/coreboot/+/67193/comment/0a348af8_52879624
PS1, Line 91: <
nit: No need to pipe in the file
If you pipe in the file, you just get the length on the output line. If you supply the file directly, you need to use cut (or some other method) to get rid of the filename on the output line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67193
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8024c6ab0c91fd9f630f37dc802ed3bc6b4608c
Gerrit-Change-Number: 67193
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Thu, 01 Sep 2022 20:43:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment