3 Jul
2020
3 Jul
'20
3:17 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43087 )
Change subject: Added GBYT4 port ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/dev... File src/mainboard/unk/gbyt4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/dev... PS1, Line 12: 0x1
0x3 is the mask for 2 ports
I see there's only one SATA port, but I'm fairly sure the mPCIe slot is actually mSATA (Bay Trail only has four PCIe lanes, and if there are four NICs using them all...)
--
To view, visit https://review.coreboot.org/c/coreboot/+/43087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99ed0c94c3255578151f940ad9b274e6f0816bfe
Gerrit-Change-Number: 43087
Gerrit-PatchSet: 1
Gerrit-Owner: Máté Kukri
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 03 Jul 2020 13:17:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment