Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39477 )
Change subject: mb/google/dedede: Enable Intel Speed Shift Technology ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39477/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39477/6/src/mainboard/google/dedede... PS6, Line 10: __weak void variant_isst_override(void) Do we need this weak function? Why not put the code inside mainboard_config_isst() directly?