[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus/variants/fleex: Update GPIOs to fix EMR

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35881 )

Change subject: mb/google/octopus/variants/fleex: Update GPIOs to fix EMR
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35881/1/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/fleex/gpio.c:

https://review.coreboot.org/c/coreboot/+/35881/1/src/mainboard/google/octopu... 
PS1, Line 29: 	PAD_NC(GPIO_138, UP_20K),
> https://partnerissuetracker.corp.google. […]

The comment still mention about physical connection only so I can understand we need the PU. But I don't see this GPIO is hook to any ACPI or FW to control?

https://review.coreboot.org/c/coreboot/+/35881/1/src/mainboard/google/octopu... 
PS1, Line 32: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 0, DEEP, NONE, Tx1RxDCRx0, DISPUPD),
> Agree, we should invert default value against baseboard value since we have invert circuit.

The external converter you point is "PMZ370UNE Q83", right? In reference board - yorp design, there is a Q83 PEN@PJE138K as well. As a result, both yorp (baseboard) and grob360s have inverter between pen_reset and pen_reset_odl.