Attention is currently required from: Felix Singer, Martin Roth, Paul Menzel, Patrick Rudolph.
Jeff Daly has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60877 )
Change subject: sb/intel/common/firmware: Hook up adding 10GbE LAN firmware
......................................................................
Patch Set 15:
(3 comments)
Patchset:
PS15:
my argument is that the same convention as the other 'optional' regions in this Kconfig. it my not be the HAVE_XXX convention that's used in other parts of coreboot Kconfig-land.
File src/southbridge/intel/common/firmware/Kconfig:
https://review.coreboot.org/c/coreboot/+/60877/comment/3a609b08_f81171d4
PS13, Line 152: HAVE_
ok, maybe it's early and i haven't gotten the crust out of my eyes yet, but how is the added 10GBE s […]
Done
https://review.coreboot.org/c/coreboot/+/60877/comment/5d2595db_bd93fd47
PS13, Line 170: HAVE_10GBE_1_BIN
Obviously, same as above.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60877
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id45ab4b69a85a5f8e52c0c4b130b6d729222b4c3
Gerrit-Change-Number: 60877
Gerrit-PatchSet: 15
Gerrit-Owner: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 07 Mar 2022 13:29:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jeff Daly
jeffd@silicom-usa.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment