Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47085 )
Change subject: libpayload/keyboard: Avoid races around input draining
......................................................................
Patch Set 2:
I'm not sure if the double `keyboard_drain_input` is still needed, or removed later. We'll see.
You mean inside keyboard_disconnect()? I left that there. Might
be a bit overcautious, obviously there is nothing supposed to
be in the hardware buffers and we didn't run anything that could
have filled the fifo.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47085
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibac9c0d04880ff4a3efda5ac53da2f9731f6602c
Gerrit-Change-Number: 47085
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 15 Nov 2020 12:31:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment