Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34770 )
Change subject: soc/mediatek: dsi: Unify format to bpp conversion
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34770/11/src/soc/mediatek/common/ds...
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/34770/11/src/soc/mediatek/common/ds...
PS11, Line 29: MIPI_DSI_FMT_RGB666
Happened to see this. Compared to kernel [1], should we return 24 here? […]
Probably, yeah. Otherwise I wouldn't know what the difference between 666 and 666_PACKED should be.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34770
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd405220b73859e5592c68f498af07eef8d7edbc
Gerrit-Change-Number: 34770
Gerrit-PatchSet: 11
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Feb 2020 01:59:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment