Nitheesh Sekar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29962 )
Change subject: qcs405: clock: Adding the clock support for qcs405 ......................................................................
Patch Set 18:
(2 comments)
https://review.coreboot.org/#/c/29962/18/src/soc/qualcomm/qcs405/clock.c File src/soc/qualcomm/qcs405/clock.c:
https://review.coreboot.org/#/c/29962/18/src/soc/qualcomm/qcs405/clock.c@251 PS18, Line 251: clock_configure(&gcc->blsp1_uart2_apps_clk, uart_cfg, 1843200,
This should probably go into uart_init(), not here.
Done in CB:32240
https://review.coreboot.org/#/c/29962/18/src/soc/qualcomm/qcs405/clock.c@259 PS18, Line 259: clock_configure(&gcc->blsp1_qup4_spi_clk, spi_cfg, 1000000,
Clock configuration for individual peripheral drivers should be done by the peripheral driver (with […]
Done in CB:32240