7 Mar
2022
7 Mar
'22
9 a.m.
Attention is currently required from: Sean Rhodes. Andy Pont has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62335 )
Change subject: ec/starlabs/merlin: Disable ACPI support last when suspending ......................................................................
Patch Set 2:
(1 comment)
File src/ec/starlabs/merlin/acpi/suspend.asl:
https://review.coreboot.org/c/coreboot/+/62335/comment/06f95589_a3806db7 PS2, Line 18: _SB.PCI0.LPCB.EC.OSFG = 0x00 I would add a comment in here that says "Disable ACPI support. This always has to be last because..." and then if anyone just looks at the code in future (without the commit message) they will know to not put anything after it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62335
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5705efab42d2fe0fd5abc6c17eeea46ead27db17
Gerrit-Change-Number: 62335
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Andy Pont andy.pont@sdcsystems.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Comment-Date: Mon, 07 Mar 2022 09:00:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment