[coreboot-gerrit] Change in coreboot[master]: cpu/intel/common: Add CAR debug Kconfig CPU_CAR_DEBUG

[Arthur Heymans (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Rizwan Qureshi, Subrata Banik, Patrick Rudolph, EricR Lai.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55653 )

Change subject: cpu/intel/common: Add CAR debug Kconfig CPU_CAR_DEBUG
......................................................................

Patch Set 2:

(1 comment)

File src/cpu/intel/common/common_init.c:

https://review.coreboot.org/c/coreboot/+/55653/comment/deb3c4a5_8a1c2462 
PS2, Line 369: 4ULL * GiB - 64 * KiB
> > I guess you are trying to avoid the bootblock here, while you're calling this inside the bootblock?
> > Make this explicit?
> > Don't run this !ENV_BOOTBLOCK
>
> won't earlier comment will take care of this as well?
>
> Arthur Heymans
> Jun 29
> Return if not ENV_CACHE_AS_RAM?

No, don't assume ENV_CACHE_AS_RAM == ENV_BOOTBLOCK.
You explicitly want to avoid you current program. (_program, _eprogram) could work for both romstage and bootblock (ENV_CACHE_AS_RAM) but some extra care needs to be taken for bootblock since _eprogram does not quite cover the full bootblock.
> > explicitly avoid addresses inside _bootblock/_ebootblock instead of making the hardcoded assumption on a 64K bootblock, which btw is simply not the case anymore in coreboot.