Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34581 )
Change subject: mb/google/kohaku: Enable stylus pen device
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34581/4/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34581/4/src/mainboard/google/hatch/...
PS4, Line 87: ACPI_GPIO_IRQ_LEVEL_LOW
The kernel driver is written more from the perspective of a devicetree implementation, and doesn't s […]
Just couple of comments:
1. As long as the kernel is capable of handling GpioIO and GpioInterrupt, I think its fine to choose one and go with that. But this should be correctly documented (probably in gpio_keys.h)
2. If we decide to go with GPIO_IRQ, I think it would be better to update gpio_keys driver to rename gpio to gpio_irq and handle it appropriately in gpio_keys.c
These can be done as follow-up changes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34581
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic252a1f90c0fc6cb9b1e426d75a8b503824681f3
Gerrit-Change-Number: 34581
Gerrit-PatchSet: 4
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philip Chen
philipchen@google.com
Gerrit-CC: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Comment-Date: Tue, 06 Aug 2019 20:08:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: SH Kim
sh_.kim@samsung.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment