1 comment:
File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
Patch Set #4, Line 87: ACPI_GPIO_IRQ_LEVEL_LOW
The kernel driver is written more from the perspective of a devicetree implementation, and doesn't s […]
Just couple of comments:
1. As long as the kernel is capable of handling GpioIO and GpioInterrupt, I think its fine to choose one and go with that. But this should be correctly documented (probably in gpio_keys.h)
2. If we decide to go with GPIO_IRQ, I think it would be better to update gpio_keys driver to rename gpio to gpio_irq and handle it appropriately in gpio_keys.c
These can be done as follow-up changes.
To view, visit change 34581. To unsubscribe, or for help writing mail filters, visit settings.