Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46840 )
Change subject: soc/amd/picasso: Update coreboot UPD variable names to include units
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46840/7/util/mainboard/google/dalbo...
File util/mainboard/google/dalboz/template/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46840/7/util/mainboard/google/dalbo...
PS7, Line 15: _sec
_s
https://review.coreboot.org/c/coreboot/+/46840/7/util/mainboard/google/tremb...
File util/mainboard/google/trembyle/template/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46840/7/util/mainboard/google/tremb...
PS7, Line 16: _sec
same
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46840
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I056a76663e84ebc940343d64178c18cb20df01a3
Gerrit-Change-Number: 46840
Gerrit-PatchSet: 7
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 04 Nov 2020 15:38:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment