Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45798 )
Change subject: soc/intel/xeon_sp/cpx: Add save_dimm_info for SMBIOS type 17 ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45798/4/src/soc/intel/xeon_sp/cpx/r... File src/soc/intel/xeon_sp/cpx/romstage.c:
https://review.coreboot.org/c/coreboot/+/45798/4/src/soc/intel/xeon_sp/cpx/r... PS4, Line 79: 0x1a Why hardcode? actKeyByte2 might work.
https://review.coreboot.org/c/coreboot/+/45798/4/src/soc/intel/xeon_sp/cpx/r... PS4, Line 88: 1200 Looks like FSP might store this in the SystemMemoryMapHob struct but headers expose it as reserved.