Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46068 )
Change subject: arch/x86/smbios: Update SMBIOS type 7 ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46068/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46068/1//COMMIT_MSG@7 PS1, Line 7: arch/x86/smbios: Update SMBIOS type 7
Populate SMBIOS type 7 with cache information
https://review.coreboot.org/c/coreboot/+/46068/1//COMMIT_MSG@8 PS1, Line 8: Please elaborate:
SMBIOS has a field to display the cache size, which is currently set to UNKNOWN undconditionally. …
https://review.coreboot.org/c/coreboot/+/46068/1/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/46068/1/src/arch/x86/smbios.c@490 PS1, Line 490: return 3; /* Unknown */ Please define a macro or enum.