build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30826 )
Change subject: security/tpm/tss/tcg-2.0: Add TPM2 function tlcl_getcapability() ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/#/c/30826/6/src/security/tpm/tss.h File src/security/tpm/tss.h:
https://review.coreboot.org/#/c/30826/6/src/security/tpm/tss.h@195 PS6, Line 195: uint32_t tlcl_extend(int pcr_num, const TPML_DIGEST_VALUES *in_digests, need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/30826/6/src/security/tpm/tss/tcg-2.0/tss.c File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/#/c/30826/6/src/security/tpm/tss/tcg-2.0/tss.c@1... PS6, Line 151: memcpy((void *) pcr_ext_cmd.digests.digests[i].digest.sha1, line over 80 characters
https://review.coreboot.org/#/c/30826/6/src/security/tpm/tss/tcg-2.0/tss.c@1... PS6, Line 156: memcpy((void *) pcr_ext_cmd.digests.digests[i].digest.sha256, line over 80 characters
https://review.coreboot.org/#/c/30826/6/src/security/tpm/tss/tcg-2.0/tss.c@4... PS6, Line 424: response = tpm_process_command(TPM2_GetCapability, &cmd, &response_size); line over 80 characters