Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38273 )
Change subject: mb/intel/jasperlake_rvp: Update FMAP for jslrvp
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38273/1/src/mainboard/intel/jasperl...
File src/mainboard/intel/jasperlake_rvp/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/38273/1/src/mainboard/intel/jasperl...
PS1, Line 7: 0xC00000
yes Justin, the SI_BIOS size needs to be 10MB, will update the changes.
Done
https://review.coreboot.org/c/coreboot/+/38273/1/src/mainboard/intel/jasperl...
PS1, Line 7: 0x400000
needs be to be re-aligned.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38273
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5724b860271025e8cb8b320ecbd33352ef779660
Gerrit-Change-Number: 38273
Gerrit-PatchSet: 2
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Justin TerAvest
teravest@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SRIDHAR SIRICILLA
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Wed, 11 Mar 2020 06:55:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin TerAvest
teravest@chromium.org
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment