Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45878 )
Change subject: tigerlake mainboards: switch to devtree aliases for PMC MUX connectors ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45878/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45878/3/src/mainboard/google/voltee... PS3, Line 20: variant_init
Ah, I hadn't looked through all of the variants to see if this would break any of the others. […]
port1 is present on all variants, right? Are we relying on the fw_config_probe on all variants to filter out the devices that don't need the change in configuration?
https://review.coreboot.org/c/coreboot/+/45878/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45878/4/src/mainboard/google/voltee... PS4, Line 29: This is an ugly hack Yep :(
https://review.coreboot.org/c/coreboot/+/45878/4/src/mainboard/google/voltee... PS4, Line 32: dev_find_matching_device_on_bus(__pci_0_1f_2->link_list, Isn't this looking at the wrong child? pmc (__pci_0_1f_2) |_ pmc_mux (generic 0) |_ pmc_mux conn (generic 0) |_ pmc_mux conn (generic 1)
Wouldn't this look for a generic 1 device under pmc and never find any matching device?