build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39373 )
Change subject: src/sb: Use 'print("%s...", __func__)' ......................................................................
Patch Set 1:
(18 comments)
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... File src/southbridge/amd/cimx/sb800/smbus.c:
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 65: if (smbus_wait_until_ready(smbus_io_base) < 0) { suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 70: printk(BIOS_DEBUG, "SB800 - Smbus.c - %s - Start.\n", __func__); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 87: printk(BIOS_DEBUG, "SB800 - Smbus.c - %s - End.\n", __func__); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 95: if (smbus_wait_until_ready(smbus_io_base) < 0) { suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 100: printk(BIOS_DEBUG, "SB800 - Smbus.c - %s - Start.\n", __func__); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 117: printk(BIOS_DEBUG, "SB800 - Smbus.c - %s - End.\n", __func__); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 125: if (smbus_wait_until_ready(smbus_io_base) < 0) { suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 130: printk(BIOS_DEBUG, "SB800 - Smbus.c - %s - Start.\n", __func__); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 150: printk(BIOS_DEBUG, "SB800 - Smbus.c - %s - End.\n", __func__); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 158: if (smbus_wait_until_ready(smbus_io_base) < 0) { suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 163: printk(BIOS_DEBUG, "SB800 - Smbus.c - %s - Start.\n", __func__); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 183: printk(BIOS_DEBUG, "SB800 - Smbus.c - %s - End.\n", __func__); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 191: printk(BIOS_DEBUG, "SB800 - Smbus.c - %s - Start.\n", __func__); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 207: printk(BIOS_DEBUG, "SB800 - Smbus.c - %s - End.\n", __func__); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 214: printk(BIOS_DEBUG, "SB800 - Smbus.c - %s - Start.\n", __func__); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 230: printk(BIOS_DEBUG, "SB800 - Smbus.c - %s - End.\n", __func__); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 240: printk(BIOS_DEBUG, "SB800 - Smbus.c - %s - Start.\n", __func__); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39373/1/src/southbridge/amd/cimx/sb... PS1, Line 259: printk(BIOS_DEBUG, "SB800 - Smbus.c - %s - End.\n", __func__); please, no spaces at the start of a line