Attention is currently required from: Subrata Banik, Reka Norman, Rizwan Qureshi, Tim Wawrzynczak, Divagar Mohandass.
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68164 )
Change subject: mb/google/brya/nivviks: Enable ISH driver and firmware name
......................................................................
Patch Set 1:
(2 comments)
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/68164/comment/a5aea246_f2b4d38f
PS1, Line 2185: ADL
ADL_N? Based on the EDS the ADL-P ID is different.
Done
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/68164/comment/2454b773_96a922db
PS1, Line 76: select DRIVERS_INTEL_ISH
nit: please keep them in alphabetical order
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68164
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89782b0b7dde1fca0130472a38628e72dfd5c26c
Gerrit-Change-Number: 68164
Gerrit-PatchSet: 1
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Daniil Lunev
dlunev@google.com
Gerrit-Reviewer: Divagar Mohandass
divagar.mohandass@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-CC: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Divagar Mohandass
divagar.mohandass@intel.com
Gerrit-Comment-Date: Fri, 07 Oct 2022 09:00:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Gerrit-MessageType: comment