mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37305 )
Change subject: sc7180: clock: Add support for QUP DFSR configuration
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37305/1/src/soc/qualcomm/sc7180/clo...
File src/soc/qualcomm/sc7180/clock.c:
https://review.coreboot.org/c/coreboot/+/37305/1/src/soc/qualcomm/sc7180/clo...
PS1, Line 233: int idx, s = qup % QUP_WRAP1_S0;
nit: please write […]
Done
https://review.coreboot.org/c/coreboot/+/37305/1/src/soc/qualcomm/sc7180/clo...
PS1, Line 249: setbits_le32(&qup_clk->dfsr_clk.cmd_dfsr,
Next push has this corrected here and in following patches: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37305
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I146ac7c2197606965265f2a770769312af76041e
Gerrit-Change-Number: 37305
Gerrit-PatchSet: 3
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Taniya Das
tdas@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Dec 2019 14:18:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: mturney mturney
mturney@codeaurora.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment