Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
Patch Set 10:
(3 comments)
please organize the i2c patches into a stack of patches. right now, they all merge-conflict with each other. also, add a "first" patch to introduce the minimal "Intel Common SoC Config" section so that the i2c tuning patches are incremental refinements to the basic structure.
https://review.coreboot.org/c/coreboot/+/42964/10/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42964/10/src/mainboard/google/volte... PS10, Line 164: # one tab.
https://review.coreboot.org/c/coreboot/+/42964/10/src/mainboard/google/volte... PS10, Line 181: .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, : .gspi[0] = { : .speed_mhz = 1, : .early_init = 1, : }, this section doesn't really relate to i2c tuning and should be split into a separate patch.
https://review.coreboot.org/c/coreboot/+/42964/10/src/mainboard/google/volte... PS10, Line 186: .i2c[0] = { : }, : .i2c[1] = { : }, : .i2c[2] = { : }, : .i2c[3] = { : }, you don't need these here because you have separate patches to add them with proper timing info.