Attention is currently required from: Michał Żygowski. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62495 )
Change subject: ec/clevo/it5570: Add Clevo EC implementation found on Clevo laptops ......................................................................
Patch Set 1:
(13 comments)
File src/ec/clevo/it5570/acpi/ec_ram.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142822): https://review.coreboot.org/c/coreboot/+/62495/comment/32c5e25b_308d224a PS1, Line 293: Offset (0xF8), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142822): https://review.coreboot.org/c/coreboot/+/62495/comment/e6fafaf0_5ea50ed8 PS1, Line 294: FCMD, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142822): https://review.coreboot.org/c/coreboot/+/62495/comment/63116246_00796a2c PS1, Line 295: FDAT, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142822): https://review.coreboot.org/c/coreboot/+/62495/comment/21782737_6beacc41 PS1, Line 296: FBUF, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142822): https://review.coreboot.org/c/coreboot/+/62495/comment/82d3031f_a171b2e0 PS1, Line 297: FBF1, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142822): https://review.coreboot.org/c/coreboot/+/62495/comment/80804a77_494553b0 PS1, Line 298: FBF2, 8, trailing whitespace
File src/ec/clevo/it5570/chip.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142822): https://review.coreboot.org/c/coreboot/+/62495/comment/8c619870_3374e8f7 PS1, Line 104: /* Depth 2 space is always avaiable, no need for conf mode */ 'avaiable' may be misspelled - perhaps 'available'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142822): https://review.coreboot.org/c/coreboot/+/62495/comment/d98fd5a8_a0fdd531 PS1, Line 107: outb(0x2e,0x2e); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142822): https://review.coreboot.org/c/coreboot/+/62495/comment/bf89d3d9_0fe82a9b PS1, Line 115: outb(0x2e,0x2e); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142822): https://review.coreboot.org/c/coreboot/+/62495/comment/0db626cd_aeec1197 PS1, Line 179: if ( curve.speed[i] < curve.speed[i-1] space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142822): https://review.coreboot.org/c/coreboot/+/62495/comment/bd08564f_d4114619 PS1, Line 283: printk (BIOS_ERR, "EC: Fan 0 curve invalid. Check your devicetree.cb.\n"); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142822): https://review.coreboot.org/c/coreboot/+/62495/comment/d6009ce5_a5acda06 PS1, Line 291: printk (BIOS_WARNING, "EC: Fan %d curve invalid. Using fan 0 curve.\n", i); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142822): https://review.coreboot.org/c/coreboot/+/62495/comment/4a22b153_801b84be PS1, Line 291: printk (BIOS_WARNING, "EC: Fan %d curve invalid. Using fan 0 curve.\n", i); space prohibited between function name and open parenthesis '('