PraveenX Hodagatta Pranesh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37275 )
Change subject: configs: Jenkins buildtest for FSP_CAR ......................................................................
Patch Set 2:
Patch Set 1: Code-Review+1
Hi Praveen,
Thanks for creating this change! Here's some tips to make it even better:
The `configs/` folder contains specific configurations that Jenkins should build-test. Since FSP CAR isn't build-tested with the current configs, adding a new config was needed. To build-test this config for every CL, and not only CB:37265, this CL should get merged in. So, the `[TEST ONLY]` prefix should be dropped.
Also, since you boot-tested Coffeelake RVP with CB:37265, it would be nice to use that config to build-test. To get a config file with only values that differ from defaults, run `make savedefconfig`; this will generate a file named `defconfig` that you can use instead.
done