Attention is currently required from: Hung-Te Lin, jason-ch chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74062 )
Change subject: soc/mediatek/mt8186: Reduce GPIO code size in bootblock
......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/mt8186/gpio.c:
https://review.coreboot.org/c/coreboot/+/74062/comment/7355b2a3_96c26887
PS2, Line 23: spi
Since TDM_RX_* are not SPI GPIOs (am I right?), we should rename this to `bootblock_gpio_driving_info`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74062
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24775ba93cd74ae401747c2f5a26bbf1c8f6ac0a
Gerrit-Change-Number: 74062
Gerrit-PatchSet: 2
Gerrit-Owner: jason-ch chen
Jason-ch.Chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: jason-ch chen
Jason-ch.Chen@mediatek.com
Gerrit-Comment-Date: Wed, 05 Apr 2023 15:01:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment