Attention is currently required from: Angel Pons, Felix Held.
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32604 )
Change subject: mb/apple: Add MacBook Air 5,2 (A1466) support ......................................................................
Patch Set 37:
(3 comments)
File src/mainboard/apple/macbookair5_2/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/32604/comment/5e8685ba_25e23dc3 PS36, Line 11: gnvs->tcrt = 100; : gnvs->tpsv = 90;
These GNVS values aren't used anywhere. So, these assignments are unnecessary.
Done
File src/mainboard/apple/macbookair5_2/cmos.default:
https://review.coreboot.org/c/coreboot/+/32604/comment/4c1f42ff_7f5142ef PS36, Line 4: me_state=Normal
Missing defaults for `nmi`, `power_on_after_fail`
Done
File src/mainboard/apple/macbookair5_2/cmos.layout:
https://review.coreboot.org/c/coreboot/+/32604/comment/848f8066_776b207f PS36, Line 27: 432 3 e 11 gfx_uma_size
After adding more enum values for `gfx_uma_size` (see comment below), its size needs to be increased […]
Done