Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42302 )
Change subject: mb/google/volteer/var/terrador: Update gpio settings and overridetree.cb
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42302/7/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/terrador/gpio.c:
https://review.coreboot.org/c/coreboot/+/42302/7/src/mainboard/google/voltee...
PS7, Line 9: static const struct pad_config gpio_table[] = {
a bunch of these GPIOs are identical to the baseboard.
you should be able to remove a bunch of duplicates.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42302
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bf9081b034bc4cd566dde45586be8309cdbb4a3
Gerrit-Change-Number: 42302
Gerrit-PatchSet: 7
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Caveh Jalali
caveh@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 16 Jun 2020 06:40:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment