HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46352 )
Change subject: soc/intel/broadwell: Drop reg-script usage from bootblock PCH init
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46352/2/src/soc/intel/broadwell/boo...
File src/soc/intel/broadwell/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/46352/2/src/soc/intel/broadwell/boo...
PS2, Line 82: RCBA32_AND_OR(HPTC, ~3, 1 << 7);
overflow if some one add new macro for 16 or 8....
I think this is no a good idea
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46352
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87145215ccec86e391d0dbd9171b08d7fd73ad9a
Gerrit-Change-Number: 46352
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 14 Oct 2020 06:42:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment