Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42829 )
Change subject: soc/amd/picasso/sb: Gate FCH AH2ALB clocks
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42829/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42829/1//COMMIT_MSG@9
PS1, Line 9: AH2ALB
What is this block? And should we always unconditionally gate the clocks?
A-Link to AHB bridge, part of the AMBA fabric.
Looks like this was spelled different in the FSP vs the PPR. I will fix to clarify as we should follow the PPR.
My understanding is these are always gated in Raven/Picasso.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42829
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcbc144a8769f8ea440cdd560bab146bf5058cf9
Gerrit-Change-Number: 42829
Gerrit-PatchSet: 1
Gerrit-Owner: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 26 Jun 2020 14:09:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment