Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46694 )
Change subject: lib/edid: Add missing name descriptor presence flag ......................................................................
lib/edid: Add missing name descriptor presence flag
EDID parser internal flag c->has_name_descriptor was never set. It was causing decode_edid() function to return NON_CONFORMANT instead of CONFORMANT even when EDID frame was correct.
Signed-off-by: Jakub Czapiga jacz@semihalf.com Change-Id: Ifdc723b892a0885cfca08dab1a5ef961463da289 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46694 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/lib/edid.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve Paul Fagerburg: Looks good to me, approved
diff --git a/src/lib/edid.c b/src/lib/edid.c index f20d239..cd7a47a 100644 --- a/src/lib/edid.c +++ b/src/lib/edid.c @@ -261,6 +261,7 @@ extract_string(x + 5, &c->has_valid_string_termination, EDID_ASCII_STRING_LENGTH)); + c->has_name_descriptor = 1; return 1; case 0xFD: {