Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x...
File src/mainboard/supermicro/x11-lga1151-series/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x...
PS16, Line 1: if BOARD_SUPERMICRO_X11SSH_TF
_BASEBOARD_ missing
No, there is no "baseboard" for these boards. x11ssh and x11ssm for example (see 35427) are different (but very similiar) boards. See Gigabyte ga-945gcm-s2l for example. This suggestion came from @hellsenberg in 32734
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35426
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29
Gerrit-Change-Number: 35426
Gerrit-PatchSet: 16
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 17 Sep 2019 07:12:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment