Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38798 )
Change subject: src/src/intel: Define HFSTS3 register
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/38798/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38798/1//COMMIT_MSG@7
PS1, Line 7: src/src/intel
soc/intel?
https://review.coreboot.org/c/coreboot/+/38798/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/38798/1/src/soc/intel/common/block/...
PS1, Line 277: if (hfs3.fields.fw_sku == ME_HFS3_FW_SKU_CUSTOM)
: return true;
: return false;
nit: return hfs3.fields.fw_sku == ME_HFS3_FW_SKU_CUSTOM;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38798
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4188e58a4a08d87be2d84674e00ed1407fb8bf82
Gerrit-Change-Number: 38798
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 10 Feb 2020 01:40:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment